Merge 102425c into 7a58639

frictionlessdata · Mar 26, 2020 · e58b9bf · e58b9bf
2 parents 7a58639 + 102425c
commit e58b9bf
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/tableschema/schema.py b/tableschema/schema.py
@@ -215,8 +215,8 @@ def remove_field(self, name):
         field = self.get_field(name)
         if field:
             predicat = lambda field: field.get('name') != name
-            self.__current_descriptor['fields'] = filter(
-                predicat, self.__current_descriptor['fields'])
+            self.__current_descriptor['fields'] = list(filter(
+                predicat, self.__current_descriptor['fields']))
             self.__build()
         return field
 

diff --git a/tests/test_schema.py b/tests/test_schema.py
@@ -420,3 +420,16 @@ def test_schema_field_time_format_issue_177():
     descriptor = {'fields':[{'name':'myfield', 'type':'time', 'format':'%H:%M:%S'}]}
     schema = Schema(descriptor)
     assert schema
+
+
+def test_schema_add_remove_field_issue_218():
+    descriptor = {
+        'fields':  [
+            {'name': 'test_1', 'type': 'string', 'format': 'default'},
+            {'name': 'test_2', 'type': 'string', 'format': 'default'},
+            {'name': 'test_3', 'type': 'string', 'format': 'default'},
+        ]
+    }
+    test_schema = Schema(descriptor)
+    test_schema.remove_field('test_1')
+    test_schema.add_field({'name': 'test_4', 'type': 'string', 'format': 'default'})