Allow casting non-strings to booleans as well

The spec is a little vague w.r.t this, but I see no harm in enabling it. In fact, when working with Excel files where booleans are represented as ints, this is quite useful.
frictionlessdata · Sep 18, 2018 · f36c385 · f36c385
1 parent b404c58
commit f36c385
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/tableschema/types/boolean.py b/tableschema/types/boolean.py
@@ -12,9 +12,8 @@
 
 def cast_boolean(format, value, **options):
     if not isinstance(value, bool):
-        if not isinstance(value, six.string_types):
-            return ERROR
-        value = value.strip()
+        if isinstance(value, six.string_types):
+            value = value.strip()
         if value in options.get('trueValues', _TRUE_VALUES):
             value = True
         elif value in options.get('falseValues', _FALSE_VALUES):

diff --git a/tests/types/test_boolean.py b/tests/types/test_boolean.py
@@ -32,6 +32,8 @@
     ('default', 'No', ERROR, {}),
     ('default', 0, ERROR, {}),
     ('default', 1, ERROR, {}),
+    ('default', 0, False, {'falseValues': [0], 'trueValues': [1]}),
+    ('default', 1, True, {'falseValues': [0], 'trueValues': [1]}),
     ('default', '3.14', ERROR, {}),
     ('default', '', ERROR, {}),
     ('default', 'Yes', ERROR, {'trueValues': ['yes']}),