Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support float for integer casting #216

Merged
merged 2 commits into from
Aug 16, 2018

Conversation

vincentchevrier
Copy link
Contributor

Added support for float or decimal types in integer casting. Casting only occurs if the float or decimal is already integer-like, otherwise it returns ERROR. fixes #215

Added support for float or decimal types in integer casting. Casting only occurs if the float or decimal is already intger-like, otherwise it returns ERROR
@roll
Copy link
Member

roll commented Aug 13, 2018

@vincentchevrier
Thanks! Could you please add a few tests?

@vincentchevrier
Copy link
Contributor Author

added an integer test

Copy link
Member

@roll roll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@roll roll merged commit 0e9045f into frictionlessdata:master Aug 16, 2018
@roll
Copy link
Member

roll commented Aug 16, 2018

@vincentchevrier
It's on its way to be released as v1.2.0 in a few minutes.

@vincentchevrier vincentchevrier deleted the integercasting branch August 16, 2018 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CastError for ints when entered as floats
2 participants