Rename cast to cast_rows

frictionlessdata · Oct 11, 2016 · 98b9a30 · 98b9a30
1 parent fbe4764
commit 98b9a30
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/lib/jsontableschema/data.rb b/lib/jsontableschema/data.rb
@@ -7,7 +7,7 @@ def load_fields!
       self['fields'] = (self['fields'] || []).map { |f| JsonTableSchema::Field.new(f) }
     end
 
-    def cast(rows, fail_fast = true)
+    def cast_rows(rows, fail_fast = true)
       @errors ||= []
       rows.map! do |r|
         begin
@@ -21,7 +21,7 @@ def cast(rows, fail_fast = true)
       rows
     end
 
-    alias_method :convert, :cast
+    alias_method :convert, :cast_rows
 
     def cast_row(row, fail_fast = true)
       @errors ||= []

diff --git a/lib/jsontableschema/table.rb b/lib/jsontableschema/table.rb
@@ -25,7 +25,7 @@ def csv_options
     def rows(opts = {})
       fail_fast = opts[:fail_fast] || opts[:fail_fast].nil?
       rows = opts[:limit] ? @csv.to_a.drop(1).take(opts[:limit]) : @csv.to_a.drop(1)
-      converted = @schema.cast(rows, fail_fast)
+      converted = @schema.cast_rows(rows, fail_fast)
       opts[:keyed] ? coverted_to_hash(@csv.headers, converted) : converted
     end
 

diff --git a/spec/data_spec.rb b/spec/data_spec.rb
@@ -98,7 +98,7 @@
 
   end
 
-  context 'convert' do
+  context 'cast_rows' do
 
     it 'converts valid data' do
       rows = [
@@ -109,7 +109,7 @@
         ['string', '10.0', '1', 'string', 'string']
       ]
 
-      converted_rows = schema.cast(rows)
+      converted_rows = schema.cast_rows(rows)
 
       converted_rows.each do |row|
         expect(row).to eq(['string', Float(10.0), 1, 'string', 'string'])
@@ -125,7 +125,7 @@
         ['string', '10.0', 'integer', 'string', 'string']
       ]
 
-      expect { schema.cast(rows) }.to raise_error(
+      expect { schema.cast_rows(rows) }.to raise_error(
         JsonTableSchema::InvalidCast,
         'not is not a number'
       )
@@ -140,7 +140,7 @@
         ['string', '10.0', 'integer', 'string', 'string']
       ]
 
-      expect { schema.cast(rows, false) }.to raise_error(
+      expect { schema.cast_rows(rows, false) }.to raise_error(
         JsonTableSchema::MultipleInvalid,
         'There were errors parsing the data'
       )
@@ -156,7 +156,7 @@
         ['string', '10.0', '1', 'string', 'string']
       ]
 
-      expect { schema.cast(rows, false) }.to raise_error(
+      expect { schema.cast_rows(rows, false) }.to raise_error(
         JsonTableSchema::MultipleInvalid,
         'There were errors parsing the data'
       )
@@ -172,7 +172,7 @@
         ['string', '10.0', '1', 'string', 'string']
       ]
 
-      expect { schema.cast(rows) }.to raise_error(
+      expect { schema.cast_rows(rows) }.to raise_error(
         JsonTableSchema::ConversionError,
         'The number of items to convert (4) does not match the number of headers in the schema (5)'
       )