This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
[parsers][m]: parse xls booleans as booleans, not integeres #232
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #230
As discussed in the issues above, xls booleans are parsed as integers - 1 for True, 0 for False. The PR checks if the type of cell
ctype
is type boolean and forces value to be booleanincludes tests
NOTE: Not sure why tests are failing, seems like they were failing before me - just run tests on master and they are failing as well.