-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the default of the PYTHON variable consistent #31
Conversation
in the mac and linux makefile.
I don't think the |
You're right. Is there even a reason that we need to resolve the symlink if |
Ok. It's just to have the directories not clash inside build, so you can do "make" and later "make PYTHON=/foo" to build another python binding side-by-side. |
That explains why we need to get the path to the python binary, but not why we need to resolve the symlink. |
Because |
Say I have two versions of python 2.7.x installed, eg. OS X system one and another one from homebrew, would they be built side by side? |
No, they'll still clash. This is however not a very important feature. I'd say just to proper detection like you mentioned, it's way better anyway. |
Sweet! |
Make the default of the PYTHON variable consistent
in the mac and linux makefile.