[blogger] Cleanups: #656
Merged
[blogger] Cleanups: #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- used `use Friendica\App;` - added type-hints for `App` and `array` where applyable - removed extra space - added other spaces
MrPetovan
requested changes
Jul 21, 2018
blogger/blogger.php
Outdated
| } | ||
|
|
||
|
|
||
| function blogger_jot_nets(&$a, &$b) | ||
| { | ||
| function blogger_jot_nets(App $a, &$b) { |
blogger/blogger.php
Outdated
| { | ||
| if (x($_POST, 'blogger-submit')) { | ||
| PConfig::set(local_user(), 'blogger', 'post', intval($_POST['blogger'])); | ||
| if (isset($_POST['blogger-submit'])) { |
There was a problem hiding this comment.
The exact equivalent to x($_POST, 'blogger-submit') is !empty($_POST['blogger-submit']).
There was a problem hiding this comment.
Aren't you supposed to sleep? 😅
- ops, curly brace in new line in function/method declaration - proper way for x() replacement
MrPetovan
approved these changes
Jul 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use Friendica\App;Appandarraywhere applyable