-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FRIO] highlighting effect when calling comment with dark themes too bright #14052
Comments
For these to be depending on the theme, the declaration of the variable would have to be in a place that is controlled by the theme. We have some JavaScript variables initialized in template files, however there aren't any provisions to pass scheme-defined variables to any template at the moment, so I'm a little stumped. |
Perhaps it is already sufficient if a value is stored at the relevant code point that represents a compromise for light and dark themes. I have done it with the values
and it seems to be more pleasant. However, I am sure that the choice of colour can be better. |
This is a good first step, however finding values that work in all three official schemes (light, dark and black) is a challenge. Any improvement is welcome though. Would you mind posting screenshots of the new colors in all three schemes? |
Looks fine to me! |
World it be possible to do the highlighting with a flashing colored margin instead? |
Yes but it would be more work than just tuning the colors of the current highlighting. |
When a comment is called up via the notification, the comment is highlighted brightly. With a dark theme, this is disproportionately bright. The changed colour values represent a compromise between light and dark themes. friendica#14052
The coloured highlighting when calling up a comment via the bell is a good function for quickly finding the position.
However, in a dark theme and when the eyes have become accustomed to the darkness, it feels like a laser beam trying to burn out the eyes.
The highlighting is controlled at this point:
friendica/view/theme/frio/js/theme.js
Line 743 in 31b74b1
Question:
https://loma.ml/display/373ebf56-1166-031a-53cd-b2e686160001
The text was updated successfully, but these errors were encountered: