Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FRIO] highlighting effect when calling comment with dark themes too bright #14052

Open
loma-one opened this issue Mar 28, 2024 · 7 comments
Open

Comments

@loma-one
Copy link

The coloured highlighting when calling up a comment via the bell is a good function for quickly finding the position.
However, in a dark theme and when the eyes have become accustomed to the darkness, it feels like a laser beam trying to burn out the eyes.

The highlighting is controlled at this point:

// Define the colors which are used for highlighting

Question:

  • Is there a way to control the effect in a theme via a CSS instruction?
  • Alternatively, is it possible to control this effect separately for light and dark themes?

https://loma.ml/display/373ebf56-1166-031a-53cd-b2e686160001

@loma-one loma-one changed the title highlighting effect when calling comment with dark themes too bright [FRIO] highlighting effect when calling comment with dark themes too bright Mar 28, 2024
@MrPetovan
Copy link
Collaborator

For these to be depending on the theme, the declaration of the variable would have to be in a place that is controlled by the theme. We have some JavaScript variables initialized in template files, however there aren't any provisions to pass scheme-defined variables to any template at the moment, so I'm a little stumped.

@loma-one
Copy link
Author

Perhaps it is already sufficient if a value is stored at the relevant code point that represents a compromise for light and dark themes.

I have done it with the values

	// Define the colors which are used for highlighting
	var colWhite = { backgroundColor: "#7f7f7f" };
	var colShiny = { backgroundColor: "#7e763a" };

and it seems to be more pleasant. However, I am sure that the choice of colour can be better.

@MrPetovan
Copy link
Collaborator

This is a good first step, however finding values that work in all three official schemes (light, dark and black) is a challenge. Any improvement is welcome though. Would you mind posting screenshots of the new colors in all three schemes?

@loma-one
Copy link
Author

loma-one commented Apr 4, 2024

This is of course a flowing colour gradient and the effect looks friendlier than shown here.
In principle, only the brightness peaks have been removed here.

2024-04-04_13-34
2024-04-04_13-35
2024-04-04_13-36

@MrPetovan
Copy link
Collaborator

Looks fine to me!

@AlfredSK
Copy link

AlfredSK commented Apr 4, 2024

World it be possible to do the highlighting with a flashing colored margin instead?

@MrPetovan
Copy link
Collaborator

Yes but it would be more work than just tuning the colors of the current highlighting.

loma-one added a commit to loma-one/friendica that referenced this issue May 16, 2024
When a comment is called up via the notification, the comment is highlighted brightly. With a dark theme, this is disproportionately bright. 

The changed colour values represent a compromise between light and dark themes. 

friendica#14052
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants