Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2019.12] PHP Warnings #7676

Closed
2 tasks
nupplaphil opened this issue Sep 29, 2019 · 26 comments · Fixed by #7785
Closed
2 tasks

[2019.12] PHP Warnings #7676

nupplaphil opened this issue Sep 29, 2019 · 26 comments · Fixed by #7785
Labels
Bug
Milestone
2019.12

Comments

@nupplaphil
Copy link
Collaborator

nupplaphil commented Sep 29, 2019 •
edited

Please report here any PHP Warning message obtained running the 2019.09 stable or 2019.12-dev versions.
Follow-up #7298

Open Tasks:
@nupplaphil nupplaphil added the Bug label Sep 29, 2019
@nupplaphil nupplaphil added this to the 2019.12 milestone Sep 29, 2019
@nupplaphil nupplaphil mentioned this issue Sep 29, 2019
Closed
@nupplaphil nupplaphil pinned this issue Sep 29, 2019
@AlfredSK
Copy link

AlfredSK commented Oct 5, 2019

2019.09 master:

PHP Warning:  A non-numeric value encountered in .../mod/profile_photo.php on line 72
PHP Warning:  A non-numeric value encountered in .../mod/profile_photo.php on line 73
PHP Warning:  Imagick::cropimage() expects parameter 3 to be integer, string given in .../src/Object/Image.php on line 612

@AlfredSK
Copy link

2019.12-dev:

[17-Oct-2019 14:02:49 Europe/Berlin] PHP Warning:  Friendica\Model\GServer::analyseRootBody(): unterminated entity reference            Poke in .../src/Model/GServer.php on line 1064
[17-Oct-2019 14:02:49 Europe/Berlin] PHP Warning:  Friendica\Model\GServer::analyseRootBody(): unterminated entity reference            Poke in .../src/Model/GServer.php on line 1120

@AndyHee
Copy link

AndyHee commented Oct 18, 2019

2019.12-dev:

PHP Warning:  Friendica\Model\GServer::analyseRootBody(): unterminated entity reference  co-host of the Audacious Compassion podcast. in /var/www/friendica/src/Model/GServer.php on line 1064
PHP Warning:  Friendica\Model\GServer::analyseRootBody(): unterminated entity reference  co-host of the Audacious Compassion podcast. in /var/www/friendica/src/Model/GServer.php on line 1064
PHP Warning:  Friendica\Model\GServer::analyseRootBody(): unterminated entity reference  co-host of the Audacious Compassion podcast. in /var/www/friendica/src/Model/GServer.php on line 1120

@ghost
Copy link

ghost commented Oct 21, 2019

2019.09 master

PHP Warning: Error while sending STMT_CLOSE packet. PID=9249 in /src/Database/Database.php on line 652

@AlfredSK
Copy link

AlfredSK commented Oct 25, 2019 •
edited by nupplaphil

2019.12-dev:

PHP Warning: is_file() expects parameter 1 to be a valid path, resource given in .../src/Module/Admin/Summary.php on line 88

Fixed by #7785

@MrPetovan MrPetovan mentioned this issue Oct 27, 2019
Closed
@nupplaphil nupplaphil mentioned this issue Oct 28, 2019
Merged
@nupplaphil nupplaphil reopened this Nov 1, 2019
@AlfredSK
Copy link

AlfredSK commented Nov 3, 2019 •
edited

2019.12-dev:

PHP Warning: Use of undefined constant max_csv_file_size - assumed 'max_csv_file_size' (this will throw an Error in a future version of PHP) in .../mod/settings.php on line 1256

Caused by #7806

@AlfredSK AlfredSK mentioned this issue Nov 3, 2019
Merged
@tobiasd tobiasd mentioned this issue Nov 3, 2019
Merged
@annando
Copy link
Collaborator

annando commented Nov 8, 2019

@AndyHee the warning MySQL server has gone away is an indicator for some issue with your MySQL server, but nothing we can fix in Friendica - and we shouldn't suppress this warning, since it indicates something where the admin has to have a look at.

@AndyHee
Copy link

AndyHee commented Nov 8, 2019

Thanks @annando noted!

@AlfredSK
Copy link

AlfredSK commented Nov 8, 2019 •
edited by MrPetovan

2019.12-dev:

[08-Nov-2019 22:02:59 UTC] PHP Warning:  call_user_func() expects parameter 1 to be a valid callback, class 'Friendica\Module\Pinned' not found in .../src/App/Module.php on line 252
[08-Nov-2019 22:02:59 UTC] PHP Warning:  call_user_func() expects parameter 1 to be a valid callback, class 'Friendica\Module\Pinned' not found in .../src/App/Module.php on line 256
[08-Nov-2019 22:02:59 UTC] PHP Warning:  call_user_func() expects parameter 1 to be a valid callback, class 'Friendica\Module\Pinned' not found in .../src/App/Module.php on line 264
[08-Nov-2019 22:02:59 UTC] PHP Warning:  call_user_func() expects parameter 1 to be a valid callback, class 'Friendica\Module\Pinned' not found in .../src/App/Page.php on line 311

Fixed by #7826

@AlfredSK AlfredSK mentioned this issue Nov 8, 2019
Merged
@annando annando mentioned this issue Nov 9, 2019
Merged
@AlfredSK
Copy link

2019.12-dev:

count(): Parameter must be an array or an object that implements Countable in .../src/Module/Profile/Contacts.php on line 49

@AlfredSK
Copy link

AlfredSK commented Nov 29, 2019 •
edited by MrPetovan

With the new ACL system I'm getting a lot...

[29-Nov-2019 06:53:35 UTC] PHP Warning:  array_unique() expects parameter 1 to be array, null given in /var/www/html/libranet/src/App/Page.php on line 286

Fixed by #7879

@AlfredSK AlfredSK mentioned this issue Nov 29, 2019
Merged
@MrPetovan
Copy link
Collaborator

On it.

MrPetovan added a commit to MrPetovan/friendica that referenced this issue Nov 29, 2019
@MrPetovan
Initialize class members in App\Page
25194b5 
- Addresses friendica#7676 (comment)
@MrPetovan MrPetovan mentioned this issue Nov 29, 2019
Merged
@AlfredSK
Copy link

AlfredSK commented Dec 2, 2019 •
edited by nupplaphil

I'm optimistic we will manage this ACL thing until the release. :-)

2019.12-dev:

[02-Dec-2019 17:32:56 UTC] PHP Warning:  count(): Parameter must be an array or an object that implements Countable in .../src/Core/ACL.php on line 345
[02-Dec-2019 17:32:56 UTC] PHP Warning:  count(): Parameter must be an array or an object that implements Countable in .../src/Core/ACL.php on line 346
[02-Dec-2019 17:32:56 UTC] PHP Warning:  count(): Parameter must be an array or an object that implements Countable in .../src/Core/ACL.php on line 347
[02-Dec-2019 17:32:56 UTC] PHP Warning:  count(): Parameter must be an array or an object that implements Countable in .../src/Core/ACL.php on line 348
[02-Dec-2019 17:32:56 UTC] PHP Warning:  implode(): Invalid arguments passed in .../src/Core/ACL.php on line 407
[02-Dec-2019 17:32:56 UTC] PHP Warning:  implode(): Invalid arguments passed in .../src/Core/ACL.php on line 408
[02-Dec-2019 17:32:56 UTC] PHP Warning:  implode(): Invalid arguments passed in .../src/Core/ACL.php on line 409
[02-Dec-2019 17:32:56 UTC] PHP Warning:  implode(): Invalid arguments passed in .../src/Core/ACL.php on line 410

After the latest fix for ACL and js_upload I pulled from develop and tested an image upload. It works. Image has the correct permissions. But I got those warnings in my PHP log.

Fixed by #7897

@MrPetovan
Copy link
Collaborator

MrPetovan commented Dec 2, 2019 •
edited

I'm optimistic we will manage this ACL thing until the release. :-)

Didn't you mean "before" instead of "until"?

Otherwise, I'd like a full trace for the first four messages, otherwise I'll have to try a bunch of separate cases where the ACL and time is precious.

@AlfredSK
Copy link

AlfredSK commented Dec 2, 2019

Possibly. But deepl.com said 'until release'. Maybe because "bis zur" (until) and "vor der" (before) has the same meaning in German.

@AlfredSK
Copy link

AlfredSK commented Dec 2, 2019

I'd like a full trace for the first four messages

Unfortunately, that's all I have. Do you think I can find out more in Friendica's log?

@MrPetovan
Copy link
Collaborator

Unlikely, this is a language error, not an application one.

MrPetovan added a commit to MrPetovan/friendica that referenced this issue Dec 3, 2019
@MrPetovan
Fix warnings about unexpected parameter array values type in ACL::get…
f989c33 
…FullSelectorHTML

- Addresses friendica#7676 (comment)
@MrPetovan MrPetovan mentioned this issue Dec 3, 2019
Merged
@AlfredSK
Copy link

AlfredSK commented Dec 4, 2019 •
edited

Looks like #7897 completely fixed #7676 (comment) - I tried it again w/o any notice/warning/error appearing in PHP log.

@MrPetovan
Copy link
Collaborator

Yay!

@ghost
Copy link

ghost commented Dec 12, 2019 

PHP Warning:  require /vendor/composer/../smarty/smarty/libs/bootstrap.php): failed to open stream: No such file or directory in /vendor/composer/autoload_real.php on line 70
PHP Warning:  require /vendor/composer/../smarty/smarty/libs/bootstrap.php): failed to open stream: No such file or directory in /vendor/composer/autoload_real.php on line 70
PHP Fatal error:  require(): Failed opening required /vendor/composer/../smarty/smarty/libs/bootstrap.php' /vendor/pear/text_languagedetect:.:/usr/share/php') in /vendor/composer/autoload_real.php on line 70

@MrPetovan
Copy link
Collaborator

Please run bin/composer.phar install --no-dev

@ghost
Copy link

ghost commented Dec 14, 2019 •
edited by nupplaphil

PHP Warning: Use of undefined constant contact - assumed 'contact' (this will throw an Error in a future version of PHP) in /src/Worker/Delivery.php on line 255

Fixed by #7949

@ghost
Copy link

ghost commented Dec 14, 2019

Please run bin/composer.phar install --no-dev

i run that after each git pull

@nupplaphil nupplaphil mentioned this issue Dec 14, 2019
Merged
@MrPetovan
Copy link
Collaborator

@copiis How often this error appears?

@ghost
Copy link

ghost commented Dec 14, 2019

@copiis How often this error appears?

once

@MrPetovan MrPetovan mentioned this issue Dec 24, 2019
Closed
@MrPetovan
Copy link
Collaborator

Closed by #7999

@MrPetovan MrPetovan unpinned this issue Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
2019.12
Development

Successfully merging a pull request may close this issue.

Fix wrong check for logfile in admin summary nupplaphil/friendica
5 participants
@nupplaphil @annando @MrPetovan @AlfredSK @AndyHee