Wrap each addon settings form in their own form tag

[MrPetovan]

• The single form tag was preventing a given addon settings to be saved if another addon had an empty required field.
• Instead of concatenating the addon form HTML through Hook::callAll, we loop manually through the hooks, appending the HTML snippets to an array.

Depends on friendica/friendica-addons#1141, please merge the addon PR first.

Closes #10314
Closes #10439

[tobiasd]

After merging this, I have no addon settings at all on my node. All themes are affected. Cleaning the SMARTY3 cache did not help.

In the PHP error log I see

PHP Notice:  Trying to access array offset on value of type null in /mod/settings.php on line 509

[tobiasd]

In the HTML source of the addon settings page I only see the wrapping HTML blocks

<form action="settings/addon" method="post" autocomplete="off">
	<input type="hidden" name="form_security_token" value="123456789">
	
</form>

[MrPetovan]

@tobiasd It looks like the select() on line 507 returns false when it really shouldn't. Can you test directly its return value?

[tobiasd]

The old SELECT * FROM `hook` WHERE `hook` = 'addon_settings'; is returning the expected results in the MySQL console I think. It lists 8 addons that look like the once I have enabled with user settings.

[MrPetovan]

It's odd that it's working on other people's node but not yours, so I'd be really curious to test the exact statement on your node.

[tobiasd]

So, what would be the exact statement be? Tell me and I'll throw it into the MariaDB console.

[MrPetovan]

I meant the PHP statement DI::dba()->select('hook', ['file', 'function'], ['hook' => 'addon_settings']), but the generated SQL statement should be SELECT `file`, `function` FROM `hook` WHERE `hook` = 'addon_settings'.

[tobiasd]

That yields to the same listing of addons.

[MrPetovan]

Is the blank display systematic? If so you might have to dig into the log for SQL errors.

[tobiasd]

It is systematic in that all users are affected yes. But the display is not blank - the Friendica UI around the listing is there. It is "just" the missing listing of the addons.

The MySQL error log is empty. I've increased the Friendica log level, but it looks like the log for the time when I visit the settings page does not hold any relevant information.

I have disabled all the addons that are returned by the query. From my understanding now there should be the info that no addons are configurable by the user right? This is not the case.

[MrPetovan]

Disabling the addons won't change anything, the PHP statement isn't returning an expected array so the foreach runs once with a null value no matter the contents of the hook table. I'm still puzzled as of why only your node (so far) is stumbling on this basic select statement.

Thanks for looking in the log, we still need to figure out the actual return value of the PHP statement.

[AlfredSK]

I'm still puzzled as of why only your node (so far)

I have checked it here. It looks like expected.

[tobiasd]

A print_r around the DBA->select yields

(
    [affected_rows] => 8
    [insert_id] => 0
    [num_rows] => 8
    [param_count] => 1
    [field_count] => 2
    [errno] => 0
    [error] => 
    [error_list] => Array
        (
        )

    [sqlstate] => 00000
    [id] => 108435
)```

And for those 8 rows the HTML form blocks are then inserted. But the `hook` information remains empty.

[tobiasd]

print_r(q("SELECT `file`, `function` FROM `hook` WHERE `hook` = 'addon_settings'"))

gives the expected array.

[MrPetovan]

Thank you, it looks like I should have used selectToArray() instead of select(), but I'm utterly puzzled about why it works for several nodes including mine and @AlfredSK 's but not yours.

[tobiasd]

Indeed, with selectToArray I see the correct listing of the addon forms. And the settings seem to work (I can save changes)