Issue 10491: Possibility for simple shortening added #10492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nupplaphil something is wrong with the tests. |
|
This PR doesn't look right, there is some remote deletion code mixed with the simple shortening. Additionally, aren't "Simple shortening" and "Intelligent shortening" mutually exclusive? |
|
@MrPetovan yeah, I mixed some experimental stuff with the intended code. The two options aren't excluding each other. The existing one is for detecting which link to take and the other one is for deciding when to cut the text. |
|
This really isn't obvious with the current setting names. 😅 |
|
I simplified your branch, between the multiple partial reverts and the merge from develop, it had 3 times the number of commits it should have had. |
MrPetovan
approved these changes
Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10491
Now it is possible to deactivate the text shortening that shortens after a line feed. When deactivated the shortening will always be at the maximum character limit.