Support for stacked profiler analysis #10551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrPetovan
requested changes
Jul 27, 2021
src/Factory/SessionFactory.php
Outdated
| @@ -58,7 +58,7 @@ class SessionFactory | |||
| */ | |||
| public function createSession(App\Mode $mode, App\BaseURL $baseURL, IConfig $config, Database $dba, ICache $cache, LoggerInterface $logger, Profiler $profiler, array $server = []) | |||
| { | |||
| $stamp1 = microtime(true); | |||
| $profiler->startRecording('parser'); | |||
There was a problem hiding this comment.
What is this "parser" category? You replaced a few calls with "rendering" in other files of this same PR.
There was a problem hiding this comment.
See some lines below. We use the "parser" key for the session stuff. And yes, this is quirky. And since "parser" is used for the cache handling, all the "parser" stuff moved to "rendering".
There was a problem hiding this comment.
Why not call it "session" then?
There was a problem hiding this comment.
That would be too easy.
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
MrPetovan
approved these changes
Jul 27, 2021
|
friendica/friendica-addons#1149 has to be merged at the same time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now the profiler could only be used for simple operations like database or file activities.
Now we support activities that call other actitivies that are profiled as well. With this we can better detect bottlenecks in more complex structures like the rendering.