Respect the postopts values for scheduled posts #10581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrPetovan
requested changes
Aug 7, 2021
| @@ -33,19 +33,23 @@ | |||
|
|
|||
| class Delayed | |||
| { | |||
| const PREPARED = 0; | |||
There was a problem hiding this comment.
Please explain the meaning of these three values as it isn’t intuitive just from the names.
There was a problem hiding this comment.
A boolean parameter has been converted to an integer parameter. Since there can be outstanding jobs in the workerqueue during the update we have to assure that it is interpreted correctly.
There was a problem hiding this comment.
I meant in the code, please. 😅
MrPetovan
approved these changes
Aug 8, 2021
|
@MrPetovan don't forget about friendica/friendica-addons#1151 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the problem that the connector settings hadn't been respected for delayed posts.