Storage refactoring #10825
Merged
Storage refactoring #10825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
nupplaphil
force-pushed
the
feat/Storage_refactor
branch
from
d1d1621
to
8e2696a
Compare
And yet you still enjoyed it, didn't you? |
MrPetovan
requested changes
Oct 4, 2021
MrPetovan
approved these changes
Oct 5, 2021
|
And how the tests are failing with the newly created Exception! |
|
I love my tests :X :D |
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
nupplaphil
force-pushed
the
feat/Storage_refactor
branch
4 times, most recently
from
bcee807
to
1993a33
Compare
nupplaphil
force-pushed
the
feat/Storage_refactor
branch
from
1993a33
to
7471b76
Compare
MrPetovan
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting the
IWritableStorage:IWritableStoragefor CRUD operations at the storage backendIStorageConfigurationto configure the storage backend@MrPetovan It wasn't that easy because of the dynamic option fetching and saving, so I had to adapt some parts of
Core\StorageManagerandModule\Admin\Storageas wellThis PR is a dependency for friendica/friendica-addons#1162
FollowUp #10582