Fixed: "Argument 1 passed to Friendica\Util\Temporal::getRelativeDate() must be of the type string, null given" #11996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrPetovan
approved these changes
Oct 15, 2022
|
Please rebase on the latest |
- $posted_date should not allow NULL, instead use `?? ''` instead - this happened in e.g. 2FA app-specific password listing
Quix0r
force-pushed
the
fixes/get-relative-time-null-parameter
branch
from
19cf4d8
to
2773ac9
Compare
|
I thought we agreed on keeping the null value possibility and testing for it first? #11900 (comment) This would remove the need for the null coalescing operator. |
- re-added `null` again friendica#11900 (comment) - removed null coalescing operator
|
I was confused there. 🙄 |
MrPetovan
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebased change on current
developcode. The original ticket was #11900 .