Remove config/addon-sample.config.php file in favor of per-addon configuration files

[MrPetovan]

Address #12135 (comment)

I got rid of the unique config/addon-sample.config.php file in favor of per-addon configuration file given #12135 (comment) where the documentation assumes some pre-existing knowledge about the config files that shouldn't be necessary. This change won't have any effect on existing installs as the existing config/addon.config.php file will still be loaded as part of the config/ folder. We just don't advertise its existence in the documentation anymore.

[nupplaphil]

I think it's now more confusing than before and I'm not sure what regressions are now possible because of the double call (because manually reloading the config inside App, it's not even sure if we catch every occurrence - like for console commands).

There are currently 5 (ordered) kind of config sources

• SOURCE_STATIC => values from default.config.php and settings.config.php
• SOURCE_FILE => any value from a custom *.config.php file from config/ or addon/*/config/
• SOURCE_DB => any value from the config table
• SOURCE_ENV => any value from an Environment variable
• SOURCE_FIX => any "fixed" value, a config could set manually in the code (currently not used)

This order is strict and ensures the order static < file < db < env

Now the other dimension is the timing and I would like to introduce the static folder in the addons as well (instead of reloading the config again), so we would have:

• Loading static/ values
• Loading addon/*/static/ values
• Loading config/ values
• Loading addon/*/config/ values
• Loading the DB
• Loading the Environment

For me, it's better understandable than reloading the core config again :-)

[edit] Therefor I'd say let's move the Core\Hook::callAll('load_config'); inside the Config class to avoid this reloading ...

[nupplaphil]

But I think I get it ... örks ...
Loading the Addons static files would needed to be after loading the db, but before loading the config, which isn't possible because the DB config is loaded through the "normal" config loading .. omg ..

[MrPetovan]

I got to the same point as you and got stuck there.

From the priority list apparently I didn't need to reload the env since it would be still be priority over the file that are loaded again.

[nupplaphil]

Ah I think this should work:

• create a static/ folder for each addon with default values
• Each addon with static folder should create a addon_load_static_config() function and load it's static files with the parameter SOURCE_STATIC (=> so it won't override the config/ values anymore)
• add a new Core\Hook::callAll('load_static_config', $loader); call at App

[MrPetovan]

Oooh, shiny. However the only thing we need is to set SOURCE_STATIC in the current hook and we're good. I'll get on it.

[MrPetovan]

Here you go.