Remove support for user.parent-uid = 0 #13169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently the tests are failing for some reason. Can you have a look at it? Also: Have you tested it on your system? |
|
I'm already testing the group => circle branch, I can't test both at the same time. Edit: Just saw you merged the PR, I'll move this branch to my node next. |
MrPetovan
force-pushed
the
task/parent-uid-null
branch
from
d9d7a75
to
b255237
Compare
|
This branch has now ran successfully on my dev node, there's no |
annando
reviewed
May 29, 2023
database.sql
Outdated
| @@ -1,6 +1,6 @@ | |||
| -- ------------------------------------------ | |||
| -- Friendica 2023.09-dev (Giant Rhubarb) | |||
| -- DB_UPDATE_VERSION 1518 | |||
| -- DB_UPDATE_VERSION 1519 | |||
There was a problem hiding this comment.
Remember to increase the database version number.
There was a problem hiding this comment.
Of course you could have also merged this PR before yours!
- uid = 0 is the system user which isn't supposed to be the parent-uid of all the non-delegate users
MrPetovan
force-pushed
the
task/parent-uid-null
branch
from
b255237
to
e9853ed
Compare
MrPetovan
force-pushed
the
task/parent-uid-null
branch
from
e9853ed
to
0a738c8
Compare
|
PR updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uid = 0 is the system user which isn't supposed to be the parent-uid of all the non-delegate users
See https://friendica.opensocial.space/display/8ffdf77c-1664-70c0-e908-261313207977