Fallback mechanism for missing IDN functions #14077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Which Debian package should this be? I had a look at 2023.12 and there it seems to be a composer dependency (from the lock file) but it was removed from there. |
|
It is |
MrPetovan
reviewed
Apr 10, 2024
| @@ -30,7 +30,7 @@ Due to the large variety of operating systems and PHP platforms in existence we | |||
| * Apache with mod-rewrite enabled and "Options All" so you can use a local `.htaccess` file | |||
| * PHP 7.4+ | |||
| * PHP *command line* access with register_argc_argv set to true in the php.ini file | |||
| * Curl, GD, GMP, PDO, mbstrings, MySQLi, hash, xml, zip, IntlChar and OpenSSL extensions | |||
| * Curl, GD, GMP, PDO, mbstrings, MySQLi, hash, xml, zip, IntlChar, IDN and OpenSSL extensions | |||
There was a problem hiding this comment.
This should read intl instead.
| @@ -27,7 +27,7 @@ Requirements | |||
| * Apache mit einer aktiverten mod-rewrite-Funktion und dem Eintrag "Options All", so dass du die lokale .htaccess-Datei nutzen kannst | |||
| * PHP 7.4+ | |||
| * PHP *Kommandozeilen*-Zugang mit register_argc_argv auf "true" gesetzt in der php.ini-Datei | |||
| * Curl, GD, GMP, PDO, mbstrings, MySQLi, hash, xml, zip, IntlChar and OpenSSL-Erweiterung | |||
| * Curl, GD, GMP, PDO, mbstrings, MySQLi, hash, xml, zip, IntlChar, IDN und OpenSSL-Erweiterung | |||
There was a problem hiding this comment.
Hier sollte stattdessen intl stehen.
Comment on lines
+499
to
+500
| DI::l10n()->t('IDN Functions PHP module'), | ||
| DI::l10n()->t('Error: IDN Functions PHP module required but not installed.'), |
MrPetovan
reviewed
Apr 10, 2024
| private static function idnToAscii(string $uri): string | ||
| { | ||
| if (!function_exists('idn_to_ascii')) { | ||
| Logger::error('IDN functions are missing.'); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #14025 (comment)