-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the log level display #14146
Conversation
{{if $row->level == "EMERGENCY"}}bg-danger | ||
{{elseif $row->level == "ALERT"}}bg-danger | ||
{{elseif $row->level == "CRITICAL"}}bg-warning | ||
{{elseif $row->level == "ERROR"}}bg-warning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't really distinguish between these 4 log levels in practice, so I would set them all to bg-danger
. On the other hand, warnings can often be ignored.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This "on the other hand" confuses me. Should I change it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I'm saying is that it is counter-productive to "hide" error and critical messages behind the Warning color which doesn't necessarily prompts an admin to react to these messages. Please have only warnings use the bg-warning
class, all the worse levels should use the bg-danger
class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed
4f780ee
to
c661a78
Compare
This improves PR #14135 by adding more loglevels.