Some more deprecated function calls are replaced #14157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrPetovan
requested changes
May 14, 2024
src/Module/Contact/Profile.php
Outdated
| @@ -24,6 +24,7 @@ | |||
| use Friendica\App; | |||
| use Friendica\BaseModule; | |||
| use Friendica\Contact\LocalRelationship; | |||
| use Friendica\Contact\LocalRelationship\Entity\LocalRelationship as EntityLocalRelationship; | |||
There was a problem hiding this comment.
Please rename the alias to LocalRelationshipEntity to satisfy the English order of qualifier.
Suggested change
| use Friendica\Contact\LocalRelationship\Entity\LocalRelationship as EntityLocalRelationship; | |
| use Friendica\Contact\LocalRelationship\Entity\LocalRelationship as LocalRelationshipEntity; |
|
Yeah, there will be some work to get rid of |
MrPetovan
approved these changes
May 14, 2024
tobiasd
reviewed
May 15, 2024
| * @deprecated 2022.03 | ||
| * @see IHandleUserSessions::getLocalUserNickname() | ||
| */ | ||
| public function getLoggedInUserNickname(): string |
There was a problem hiding this comment.
This seems to be used by the calendar, see #14025 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several more function calls are now replaced and some legacy functions are completely removed now.