Issue #2792 #2798
Merged
Issue #2792 #2798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 24, 2016 11:50
- Add a condition to check if the current user is amongst the responses - Populate the responses array with the self attribute
- Add active class when the self attribute is found - Add CSS styling to active response links
- Move rotator from hidden block to post header
|
For me the condition looks fine. The "uid" contains the user that owns the item. And "self" just tells if the item was created by the user that owns the item. Now the nasty part: Could you add your changes to the other (maintained) themes as well? Thanks! |
added 2 commits
September 25, 2016 09:49
- Update general wall_thread.tpl - Add specific styles for duepuntozero
- Add active classes to wall_thread.tpl - Add styles - Fix event icon not appearing at full opacity on hover
Yes but I won't accept any liability for ugly design. Also I see way more themes in the theme folder than in the active theme list in the admin, is it because they all are deprecated? |
|
Yes. The supported themes are the ones where the file |
added 5 commits
September 25, 2016 10:29
- Added active class to wall_thread.tpl - Added styles - Fixed background-size declarations to be able to add padding to icons
- Add active classes to wall_thread.tpl, search_item.tpl and photo_item.tpl - Add styles both in the master LESS file and the generated variant CSS themes
- Added "self" class to wall_thread.tpl to avoid conflict with the already existing "active" class - Added style
- Add active class to wall_thread.tpl, search_item.tpl, photo_item.tpl - Add style Note: because of an !important in the Dark variant stylesheet, the active links won't show up
- Added active class to search_item.tpl
|
It's done. Phew! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Issue #2792
Not sure about the following condition to know if the current user is among the reactions:
if((local_user()) && (local_user() == $item['uid']) && ($item['self']))It seems to work on as expected on my single-user instance, but I'm not exactly sure about the meaning of
uidandself.