Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GROUP BY in dbstructure #3442

Merged
merged 3 commits into from
May 7, 2017
Merged

Conversation

Alkarex
Copy link

@Alkarex Alkarex commented May 7, 2017

@Alkarex
Copy link
Author

Alkarex commented May 7, 2017

The updated DB number might not be necessary, but it was to re-trigger the update process after the fix.
Since my instance was crashed in the middle of the update process, I had to manually do:

update configuration set v = 0 where k = 'maintenance';

@@ -398,6 +398,12 @@ function update_structure($verbose, $action, $tables=null, $definition=null) {
$sql3 .= ";";
}

$field_list = '';
Copy link
Collaborator

@annando annando May 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this part should only be done when $ignore was false and $unique was true, since only then the following problematic queries are executed.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should now be addressed accordingly 354531b

@annando
Copy link
Collaborator

annando commented May 7, 2017

The updated number isn't necessary. (I had overseen that, could you change that back?) You simply could run php include/dbstructure.php update in the command line to retry the database changes. This would also reset the maintenance settings.

BTW: To reset the maintenance you can call php util/maintenance.php 0.

@Alkarex
Copy link
Author

Alkarex commented May 7, 2017

Here you are. And thanks for the info.

@annando
Copy link
Collaborator

annando commented May 7, 2017

You might want to reset the database version in the config table to that the next database updates will be performed.

@annando annando merged commit 9c3e968 into friendica:develop May 7, 2017
@Alkarex Alkarex deleted the any_value_dbstructure branch May 7, 2017 10:48
@MrPetovan MrPetovan added this to the 3.5.2 milestone May 7, 2017
Quix0r pushed a commit to Quix0r/friendica that referenced this pull request Jul 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants