-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GROUP BY in dbstructure #3442
Conversation
The updated DB number might not be necessary, but it was to re-trigger the update process after the fix. update configuration set v = 0 where k = 'maintenance'; |
@@ -398,6 +398,12 @@ function update_structure($verbose, $action, $tables=null, $definition=null) { | |||
$sql3 .= ";"; | |||
} | |||
|
|||
$field_list = ''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this part should only be done when $ignore
was false
and $unique
was true
, since only then the following problematic queries are executed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should now be addressed accordingly 354531b
The updated number isn't necessary. (I had overseen that, could you change that back?) You simply could run BTW: To reset the maintenance you can call |
Here you are. And thanks for the info. |
You might want to reset the database version in the config table to that the next database updates will be performed. |
#3440