Move oembed to src #4156
Merged
Move oembed to src #4156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 1, 2018
annando
requested changes
Jan 1, 2018
src/Content/OEmbed.php
Outdated
| <?php | ||
|
|
||
| /* | ||
| * To change this license header, choose License Headers in Project Properties. |
There was a problem hiding this comment.
These lines confusing me. Are these place holders?
Additionally @file is missing.
src/Content/OEmbed.php
Outdated
| require_once 'mod/proxy.php'; | ||
|
|
||
| /** | ||
| * Description of OEmbed |
There was a problem hiding this comment.
A little bit too generic, I think.
src/Content/OEmbed.php
Outdated
| public static function replaceCallback($matches) | ||
| { | ||
| $embedurl = $matches[1]; | ||
| $j = OEmbed::fetchURL($embedurl); |
There was a problem hiding this comment.
Wouldn't self:: be better here? (Same goes for the line below and much other places)
src/Content/OEmbed.php
Outdated
| private static function buildXPath($attr, $value) | ||
| { | ||
| // https://www.westhoffswelt.de/blog/2009/6/9/select-html-elements-with-more-than-one-css-class-using-xpath | ||
| return "contains( normalize-space( @$attr ), ' $value ' ) or substring( normalize-space( @$attr ), 1, string-length( '$value' ) + 1 ) = '$value ' or substring( normalize-space( @$attr ), string-length( @$attr ) - string-length( '$value' ) ) = ' $value' or @$attr = '$value'"; |
There was a problem hiding this comment.
There are several spaces in that line that could be removed to make it look better.
There was a problem hiding this comment.
Some spaces are required are it is looking for a value in a space-separated list, but there are a several others I can indeed remove.
Merged
- Add file comment in Content\OEmbed - Add self where relevant - Remove useless spaces from the XPath expression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4155
Part of #3878
Part of #4090
This is just a preparation for the work that hopefully will be agreed upon in #4155