Use short form array syntax everywhere

[MrPetovan]

BECAUSE I CAN!

This is a nearly impactless PR, the only functional change is in util/po2php.php where I had to manually change how we generate arrays in the string.php files.

[tobiasd]

This is a nearly impactless PR, the only functional change is in `util/po2php.php` where I had to manually change how we generate arrays in the `string.php` files.

But you tested the po2php mechanism and it still works? ;-)

[MrPetovan]

That's where you come in, how do I test it?

[tobiasd]

You can compile the French translation from the messages.po file and see if it still works.

$> php util/po2php.php view/lang/fr/messages.po 
$> php -l view/lang/fr/strings.php

If this does not throw a syntax error, then you can try and load the FR translated interface in Friendica.

[MrPetovan]

There are no differences between the generated file and the one I changed directly in this PR 🎉

[MrPetovan]

Changing language doesn't work at the moment, but it is unrelated to this PR.

[MrPetovan]

Fixed the language selection, tested it successfully with this PR.

[MrPetovan]

Can someone please merge this, I've had to rebase it 4 times to fix conflicts since I opened it because @zeroadam keeps deleting files in include!

[annando]

Sorry, I'm currently at reviewing it (I'm now at "include/post_update.php"), but my hand is aching from pressing the page down key (no joke, I'm susceptible for getting a carpal tunnel syndrome, I already had two hand surgeries)

I have to stop for some hours until I can continue.

[MrPetovan]

For once, I did a straightforward PR that doesn’t require manual review, sorry you started doing this.

[annando]

I will always have a look at every code line at PRs - this is my standard. :)

[zeroadam]

Sorry about that! I will pause any further work until this is merged. Rebasing can be a giant pain!!

[MrPetovan]

Please continue, it’s only blocking me, I’m reluctant to make any new changes before this is merged.

[annando]

@zeroadam if you review it, I could press the magic button. I just want to have a second pair of eyes that looked at the changes.

[zeroadam]

👍

[annando]

A:

And what had you done this evening?

B:

I reviewed a single pull request.

[zeroadam]

@annando hahhah..

I was reviewing, though it was taking quite some time. Saved by the bell!

[MrPetovan]

Thanks!

[annando]

@zeroadam Sorry, I haven't seen that you started it as well.

[annando]

@MrPetovan You owe me one :)

[MrPetovan]

I already reviewed all of @Quix0r formatting PR, and I'll review all of your item changes PR, so I think I'm good! 😄

Sorry for the ordeal though.

[zeroadam]

No worries!!

…

On Mon, Jan 15, 2018, 17:17 Hypolite Petovan ***@***.***> wrote: I already reviewed all of @Quix0r <https://github.com/quix0r> formatting PR, and I'll review all of your item changes PR, so I think I'm good! 😄 Sorry for the ordeal though. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4243 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFyWzLPXg3RvyxZSfOk7KgpT3-5TvZe1ks5tK86VgaJpZM4ReZKx> .