Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move plaintext to src #4335

Merged
merged 5 commits into from Jan 27, 2018
Merged

Move plaintext to src #4335

merged 5 commits into from Jan 27, 2018

Conversation

zeroadam
Copy link

Move plaintext to src class

Related to #3878

@zeroadam
Create Plaintext class
792f069 
create Plaintext class with functions from include/plaintext
@zeroadam
Update function calls
21881f2 
update to new function calls
@zeroadam
Remove requires
11c7441 
remove require_once statements
@zeroadam
Remove old file
c437b0c 
remove include/plaintext.php
@zeroadam zeroadam mentioned this pull request Jan 27, 2018
Merged
MrPetovan
MrPetovan requested changes Jan 27, 2018
View reviewed changes
Copy link
Collaborator

@MrPetovan MrPetovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attachements actually are in the BBcode realm, please create the BBCode vlass instead 😅

@zeroadam
Copy link
Author

Will do

@zeroadam
Rename class to BBCode
177edd2 
Rename Plaintext class to BBCode
@MrPetovan MrPetovan merged commit c3db62f into friendica:develop Jan 27, 2018
@zeroadam
Copy link
Author

There is a PR in addons as well

@zeroadam zeroadam deleted the feature/Plaintext branch January 27, 2018 01:11
@MrPetovan
Copy link
Collaborator

Done as well, although I’d like you to move BBCode::shortenMsg() to Plaintext::shorten()

@MrPetovan MrPetovan added this to the 3.6 milestone Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrPetovan MrPetovan MrPetovan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.6
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zeroadam @MrPetovan