Fix wrong use of class constants in DFRN #5036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had a bunch of errors of the following type (PHP 7.2.3 / Ubuntu 18.04 LTS) |
|
Could you change the target of the PR to the 2018.05-rc branch? this is clearly a bugfix and not a new feature. |
|
Here you are, @tobiasd |
MrPetovan
requested changes
May 13, 2018
src/Protocol/DFRN.php
Outdated
| @@ -2141,7 +2141,7 @@ private static function updateContent($current, $item, $importer, $entrytype) | |||
|
|
|||
| $changed = true; | |||
|
|
|||
| if ($entrytype == DFRN_REPLY_RC) { | |||
| if ($entrytype == DFRN::DFRN_REPLY_RC) { | |||
There was a problem hiding this comment.
It should be DFRN::REPLY_RC instead, can you please rename all DFRN_* constants to just * and modify their use?
MrPetovan
approved these changes
May 13, 2018
|
Pleasure doing business with you sir! |
MrPetovan
changed the title
Quix0r
pushed a commit
to Quix0r/friendica
that referenced
this pull request
May 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://php.net/manual/language.oop5.constants.php