i18n ru intval bug #5072
Merged
i18n ru intval bug #5072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should fix: Got error 'PHP message: PHP Warning: A non-numeric value encountered in /home/alex/public_html/f.a80.fr/view/lang/ru/strings.php on line 5\n PHP 7.2.5 / Ubuntu 18.04 LTS
|
I'm not sure this will help much. The strings.php file will be recreated once there is a new translation at Transifex. So the question is, why the line was not added to the strings file the last time it was recreated. |
|
Consistently no of the other translation files have that line. The generation process of the strings file (console po2php) needs to be fixed. |
|
Ok, and the tests fail only for PHP 7.1. There seems to be something strange there... |
|
Regarding the testing, see #5066 |
|
Do you like to run something like to recreate the strings.php files for all the languages to add the new line everywhere? (it is fish syntax, your shell might need a different one) |
```sh for i in view/lang/*/messages.po; do bin/console po2php $i; done ```
|
Done |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix:
PHP 7.2.5 / Ubuntu 18.04 LTS