Moved global PAGE_* to Profile class

[Quix0r]

This PR is similar to #5490 and moves all PAGE_* (global namespace) to Friendica\Model\Profile class. There is also one addon (forumdirectory) that needs change (already done, PR will depend on this).

[annando]

I don't think that "profile" is the correct class. It belongs to the user. Additionally I prefer if you would move the "ACCOUNT_TYPE_" constants as well, since they belong to these "PAGE_" constants.

[Quix0r]

@MrPetovan told me to do so.

[annando]

A user can have multiple profiles. But these types are assigned to the user table, not the profile table.

Update: Possibly the Contact class is even better, since we use this constant in combination with the contact table as well.

[MrPetovan]

My mistake, I saw that page-flags were queried in a profile table query, but I didn't realize it was coming from the user table. It should then be in the Friendica\Model\User class, I'm sorry about that.

[MrPetovan]

The constants should be in Model\User instead, I'm sorry about that.

[Quix0r]

It is okay. Will do it tomorrow.

[annando]

Or it is Model\Contact since we use it as well for contacts?

[MrPetovan]

Do we use it the same exact way? Does it count for non-Friendica contacts?

[annando]

It is used in the same way. It is in contact-type - the user field is account-type.

I'm unsure if DFRN would be ideal? But when we possibly switch to AP, we surely would transmit this over there as well.

[MrPetovan]

I think there should be a distinction between both, and we should have a copy of the constants in Model\User and in Model\Contact to avoid confusion.

[annando]

I think this duplication would confuse even more, since we fill the user constant on the sender side and use it with the contact constant on the receiver side.

[MrPetovan]

In this case I would put it in Model\Contact.

[Quix0r]

One hour ago was the last comment, then I presume that Friendica\Model\Contact is final?

[annando]

I'm fine with it. But please also add this second group of constants I mentioned, since they are some kind of subgroup.

[Quix0r]

Done as requested and rebased branch against develop.

[MrPetovan]

This is the wrong syntax.

[Quix0r]

Over-heat problem detected. ;-)

[Quix0r]

Done.

[Quix0r]

Oh, again. :-( TemperatureOutOfBoundsException