Update "mrpetovan" email address #5764
Conversation
- Fix Tobias' email address - Fix copypasted doc block in Console/PostUpdate
|
Is @tobiasd with his address being added? |
|
I found his address in other files, I didn't expect it to be a point of contention but I'm definitely open to whatever his decision may be. |
| @@ -37,8 +37,8 @@ | |||
| * set to the value of the last parameter. (e.g. "system loglevel 0" will | |||
| * disable logging) | |||
| * | |||
| * @author Tobias Diekershoff | |||
| * @author Hypolite Petovan <mrpetovan@gmail.com> | |||
| * @author Tobias Diekershoff <tobias.diekershoff@gmx.net> | |||
There was a problem hiding this comment.
That field is not the email address but the webby and is interpreted by the addon view in the admin panel as link to the profile of the author... So this is clearly wrong information there, as my profile is not lying at gmx.net
There was a problem hiding this comment.
Ok, forget it, we are not in the addon m) But why does this information now have to be in the file header? Is there any good reason?H ow much of the file did I really author?
There was a problem hiding this comment.
You authored the original CLI script that I later converted to a Console command, so you deserve to be credited.
This information is in the header because we can. It would be typically displayed in an automatically generated code documentation.
|
You authored the original CLI script that I later converted to a
Console command, so you deserve to be credited.
I think that _if_ we put this information in a file, it _should_ be included in **all** files, not only a few and then list all persons who ever worked on these files.
|
|
Maybe so, but this isn't the point of this PR at all. |
|
If @tobiasd don't mind, we should merge this PR. Later we can decide what to do in other files. |
|
No, it was just a general remark |
Addon side: friendica/friendica-addons#736