Remove x() #6219
Merged
Remove x() #6219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove extraneous parentheses around empty() calls - Remove duplicate calls to intval(), count() or strlen() after empty() - Replace ternary operators outputting binary value with empty() return value - Rewrite defaults() without x()
|
Can you have a look at the failed tests? |
|
Bless @nupplaphil. |
|
Given its extensiveness, this PR blocks me for further development. |
|
I had been on our companies Christmas party yesterday, so I had been blocked in some way as well :-) I will have a look at it today, but hopefully some second (or third) pair of eyes could have a look as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prank where we had a custom global function that did the same as a PHP native function but worse is now over.
I'm running this branch, so far so good.
Due to the fact that this PR removes a function used by addons, friendica/friendica-addons#779 should be merge BEFORE this one to prevent border case fatal errors.
Ideally, addons should also be pulled before the core as well.