Fix database error ""Unknown column 'parent-item.author-id'"

[annando]

Adressed here: #8473 (comment)

[MrPetovan]

I feel like the condition on lines 794-796 should be enclosed in the condition on lines 790-792 because it won't happen on its own anymore,

[annando]

I think that this looks more beautiful:

		if ((strpos($sql_commands, "`parent-item`.") !== false) || (strpos($sql_commands, "`parent-item-author`.") !== false)) {
			$joins .= " STRAIGHT_JOIN `item` AS `parent-item` ON `parent-item`.`id` = `item`.`parent`";
		}

		if (strpos($sql_commands, "`parent-item-author`.") !== false) {
			$joins .= " STRAIGHT_JOIN `contact` AS `parent-item-author` ON `parent-item-author`.`id` = `parent-item`.`author-id`";
		}

Than this:

		if ((strpos($sql_commands, "`parent-item`.") !== false) || (strpos($sql_commands, "`parent-item-author`.") !== false)) {
			$joins .= " STRAIGHT_JOIN `item` AS `parent-item` ON `parent-item`.`id` = `item`.`parent`";

			if (strpos($sql_commands, "`parent-item-author`.") !== false) {
				$joins .= " STRAIGHT_JOIN `contact` AS `parent-item-author` ON `parent-item-author`.`id` = `parent-item`.`author-id`";
			}
		}

[MrPetovan]

Yes but it makes less sense since one depends on the other. The parent-item-author table alias will never be present independently from the parent-item alias so it makes sense to group them visually instead of having them separated on the same visual plan.