Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid fatal error on the community page #9248

Merged
merged 2 commits into from
Sep 20, 2020
Merged

Conversation

annando
Copy link
Collaborator

@annando annando commented Sep 20, 2020

This should fix this fatal error:

[Sun Sep 20 19:23:19.574692 2020] [php7:error] [pid 25996] [client 192.168.102.50:52726] PHP Fatal error:  
Uncaught TypeError: Argument 1 passed to Friendica\\Model\\Contact::getByURL() must be of the type string, null given, called in /var/www/html/src/Model/Contact.php on line 2518 and defined in /var/www/html/src/Model/Contact.php:207
Stack trace:
#0 /var/www/html/src/Model/Contact.php(2518): Friendica\\Model\\Contact::getByURL(NULL, false)
#1 /var/www/html/src/Object/Post.php(985): Friendica\\Model\\Contact::magicLink(NULL)
#2 /var/www/html/src/Object/Post.php(286): Friendica\\Object\\Post->checkWallToWall()
#3 /var/www/html/src/Object/Thread.php(207): Friendica\\Object\\Post->getTemplateData(Array)
#4 /var/www/html/include/conversation.php(679): Friendica\\Object\\Thread->getTemplateData(Array)
#5 /var/www/html/src/Module/Conversation/Community.php(104): conversation(Object(Friendica\\App), Array, 'community', false, false, 'commented', 1)
#6 [internal function]: Friendica\\Module\\Conversation\\Community::content(Array)
#7 /var/www/html/src/App/Page.php(331): call_user_func(Array, Array)
#8 /var/www/html/src/App/Page.php(38 in /var/www/html/src/Model/Contact.php on line 207, referer: https://f.nospy.net/display/ec054ce7-845f-6780-1213-61e875841323

See here: https://forum.friendi.ca/73b2629d-695f-6790-afd6-62c731724465

@tobiasd tobiasd added the Bug label Sep 20, 2020
@tobiasd tobiasd added this to the 2020.09 milestone Sep 20, 2020
@tobiasd
Copy link
Collaborator

tobiasd commented Sep 20, 2020

You say when you are ready?

@annando annando mentioned this pull request Sep 20, 2020
@annando
Copy link
Collaborator Author

annando commented Sep 20, 2020

Should be done now.

@tobiasd tobiasd merged commit 886cd9a into friendica:2020.09-rc Sep 20, 2020
@annando annando deleted the fatal branch September 20, 2020 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants