Babel: Support tweet URL #9916
Merged
Babel: Support tweet URL #9916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested or untested? |
|
Tested with a successful case:
It was pivotal in solving #9915, and I may need it in the future, but since it's a debug tool I didn't want to spend that long making sure all the negative cases are gracefully handled. |
|
I will have a look at the open PRs this evening. At the weekend I had been busy watching the FOSDEM and needed some time to recreate. P.S.: Is there any merge order? |
|
Nope, all are independent unless explicitly written (like this one depending on friendica/friendica-addons#1080) |
MrPetovan
force-pushed
the
task/babel-twitter-url
branch
from
ddd339a
to
740ada6
Compare
MrPetovan
force-pushed
the
task/babel-twitter-url
branch
from
740ada6
to
b2680bf
Compare
|
Please don't forget about friendica/friendica-addons#1080 this PR depends on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on friendica/friendica-addons#1080
Highly experimental feature, absolutely no error catching, here be dragons.