Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bundler to 2.1.4 #116

Merged
merged 1 commit into from
Jan 28, 2021
Merged

Update bundler to 2.1.4 #116

merged 1 commit into from
Jan 28, 2021

Conversation

pelargir
Copy link
Collaborator

This updates our gemspec to use a more recent version of bundler (bundler 2.1.4 is included with Ruby 2.7.2).

Copy link
Contributor

@mamhoff mamhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, but we allow older Rubies as well. The gem is compatible with older bundlers, and with newer bundlers, and I think we should keep that version window as wide as possible.

@mamhoff mamhoff closed this Jan 27, 2021
@tvdeyen
Copy link
Collaborator

tvdeyen commented Jan 27, 2021

Thank you, but we allow older Rubies as well. The gem is compatible with older bundlers, and with newer bundlers, and I think we should keep that version window as wide as possible.

FYI this is a dev dependency that only gets installed on the local machine while your writing the gem. This should not effect anybody else using the gem

@pelargir
Copy link
Collaborator Author

@tvdeyen Right. I don't see a problem with requiring Bundler 2 in this situation. Bundler 1 was last updated over 2 years ago and the only advantage it offers over 2 is access to now-deprecated Ruby and RubyGems versions.

@tvdeyen
Copy link
Collaborator

tvdeyen commented Jan 27, 2021

Yes, 2FA support for pushing to Rubygems is one it

@tvdeyen
Copy link
Collaborator

tvdeyen commented Jan 27, 2021

@mamhoff I think we should re-open this PR

@mamhoff
Copy link
Contributor

mamhoff commented Jan 28, 2021

Sorry, @pelargir - I did not realize we're talking about a dev dependency here.

@mamhoff mamhoff reopened this Jan 28, 2021
@mamhoff mamhoff dismissed their stale review January 28, 2021 18:15

Realizing I was wrong requesting this change

@mamhoff mamhoff self-requested a review January 28, 2021 18:15
@pelargir
Copy link
Collaborator Author

Thanks!

@pelargir pelargir merged commit 1df381b into main Jan 28, 2021
@pelargir pelargir deleted the update-bundler branch January 28, 2021 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants