-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bundler to 2.1.4 #116
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, but we allow older Rubies as well. The gem is compatible with older bundlers, and with newer bundlers, and I think we should keep that version window as wide as possible.
FYI this is a dev dependency that only gets installed on the local machine while your writing the gem. This should not effect anybody else using the gem |
@tvdeyen Right. I don't see a problem with requiring Bundler 2 in this situation. Bundler 1 was last updated over 2 years ago and the only advantage it offers over 2 is access to now-deprecated Ruby and RubyGems versions. |
Yes, 2FA support for pushing to Rubygems is one it |
@mamhoff I think we should re-open this PR |
Sorry, @pelargir - I did not realize we're talking about a dev dependency here. |
Realizing I was wrong requesting this change
Thanks! |
This updates our gemspec to use a more recent version of bundler (bundler 2.1.4 is included with Ruby 2.7.2).