Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing error message during handshake (Too many connections) #83

Merged
merged 1 commit into from
Oct 12, 2018

Conversation

clue
Copy link
Contributor

@clue clue commented Oct 11, 2018

The server may reject an incoming connection during authentication or even before that during the initial connection handshake. The initial handshake error message uses a slightly different message format and also semantically happens before executing a command, so we now make sure to properly reject the following authentication command.

Note:
In case the server sent a ERR packet as first packet it will happen before the client and server negotiated any capabilities. Therefore the ERR packet will not contain the SQL-state.

https://dev.mysql.com/doc/dev/mysql-server/latest/page_protocol_connection_phase.html

Resolves / closes #81

@jsor jsor merged commit ed7fe8b into friends-of-reactphp:master Oct 12, 2018
@clue clue deleted the too-many-connections branch October 12, 2018 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Too many connections' error is not properly handled
3 participants