App hierarchy #152
Merged
App hierarchy #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fahad19
requested review from
a user,
mAiNiNfEcTiOn,
alexmiranda,
markvincze,
AlexDudar,
GVdP-Travix and
jvantillo
AlexDudar
reviewed
Mar 26, 2017
|
|
||
| expect(() => widget.setRegion('sidebar')).to.throw(/No root app instance available/); | ||
| }); | ||
| // expect(() => widget.setRegion('sidebar')).to.throw(/No root app instance available/); |
There was a problem hiding this comment.
I moved all the tests of frint v0.x to frint-compat and kept them unchanged to make sure we can depend on frint-compat reliably.
If I really had to remove any individual test, I added a NOTE on top of the commented block explaining why it's not needed any more.
Just to keep a reference.
markvincze
approved these changes
Mar 27, 2017
AlexDudar
approved these changes
Mar 27, 2017
mAiNiNfEcTiOn
approved these changes
Mar 27, 2017
alexmiranda
approved these changes
Mar 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done
Root App ==> WidgethierarchyRoot App ==> As ==> Many ==> Apps ==> WidgetFuture
This PR now makes way for things like: