Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rendering twice issue #2

Merged
merged 1 commit into from
Jul 8, 2016
Merged

Fix rendering twice issue #2

merged 1 commit into from
Jul 8, 2016

Conversation

alexmiranda
Copy link
Contributor

Issue:
Region component was rendered twice because of setState being called during componentDidMount

Fix
Change componentDidMount to componentWillMount.

fahad19
fahad19 reviewed Jul 8, 2016
View reviewed changes
package.json
@@ -1,6 +1,6 @@
{
"name": "frint",
"version": "0.2.4",
"version": "0.2.5",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don't update the version numbers in PRs. we do it via npm version while releasing separately :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@fahad19 fahad19 merged commit fb498fb into frintjs:master Jul 8, 2016
@alexmiranda alexmiranda deleted the fix_rendering_twice_issue branch July 15, 2016 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexmiranda @fahad19