Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: for mapToProps, createApp, and middleware #36

Merged
merged 4 commits into from
Oct 30, 2016
Merged

Tests: for mapToProps, createApp, and middleware #36

merged 4 commits into from
Oct 30, 2016

Conversation

fahad19
Copy link
Member

@fahad19 fahad19 commented Oct 29, 2016 •
edited
Loading

What's done

  • Added tests for mapping Model to props via mapToProps
  • Added tests for createApp
  • Added tests for internal appendAction middleware
  • Add badge to Coveralls in README

@coveralls
Copy link

Coverage Status

Coverage increased (+3.02%) to 86.415% when pulling 41254e7 on test-maptoprops-model into 2ea4205 on master.

@fahad19 fahad19 changed the title Tests: for mapping Model to props via mapToProps Tests: for mapToProps, createApp, and appendAction middleware Oct 29, 2016
@fahad19 fahad19 changed the title Tests: for mapToProps, createApp, and appendAction middleware Tests: for mapToProps, createApp, and middleware Oct 29, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+6.8%) to 90.189% when pulling 457bedd on test-maptoprops-model into 2ea4205 on master.

@fahad19
Copy link
Member Author

fahad19 commented Oct 29, 2016

Finally hit the 90% mark, and on the greener side of the badge \o/

alexmiranda
alexmiranda approved these changes Oct 30, 2016
View reviewed changes
Copy link
Contributor

@alexmiranda alexmiranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@fahad19 fahad19 merged commit 51f79ee into master Oct 30, 2016
@fahad19 fahad19 deleted the test-maptoprops-model branch October 30, 2016 13:46
@fahad19 fahad19 added the patch label Oct 30, 2016
@fahad19 fahad19 self-assigned this Oct 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmiranda alexmiranda alexmiranda approved these changes

@markvincze markvincze markvincze approved these changes

Assignees

@fahad19 fahad19

Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fahad19 @coveralls @alexmiranda @markvincze