fix OnColumnChange to work with relationship based updates

frioux · Nov 2, 2012 · f3a9244 · f3a9244
1 parent 2f973a6
commit f3a9244
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/Changes b/Changes
@@ -1,6 +1,9 @@
 Revision history for {{$dist->name}}
 
 {{$NEXT}}
+       - fix OnColumnChange to work with relationship based updates
+         so $artist->update({ cd => $cd_obj }) now correctly triggers
+         a change.  Thanks David Schmidt for the test
        - validate number of arguments to _change_column (David Schmidt)
        - fix name of Helper::ResultSet::Shortcut in SYNOPSIS
 

diff --git a/lib/DBIx/Class/Helper/Row/OnColumnChange.pm b/lib/DBIx/Class/Helper/Row/OnColumnChange.pm
@@ -69,7 +69,10 @@ sub after_column_change {
 sub update {
    my ($self, $args) = @_;
 
-   my %dirty = ( $self->get_dirty_columns, %{$args||{}} );
+   $self->set_inflated_columns($args) if $args;
+
+   my %dirty = $self->get_dirty_columns
+     or return $self;
 
    my @all_before = @{$self->_before_change || []};
    my @all_around = @{$self->_around_change || []};