Feature: Best Practices check

[mcsnolte]

Similar to how PBP are checked with https://metacpan.org/pod/Perl::Critic it would be very useful for doing something similar for DBIC Schemas. Here are some examples:

• Relationship names should not match column names
• NULL-able belongs_to relationships should use LEFT join type

[frioux]

also non null belongs_to should not use left.

[mcsnolte]

more things to try and check:

• relationships to a single record is singular
• relationships to multiples is plural

tricky, but maybe could check for add_fk_index not enabled on relationships to large tables

[mcsnolte]

also warn on duplicate relationship definitions under different names to prevent errors stemming from copy and paste.

[frioux]

good one!

[frioux]

We can use this to implement these: https://metacpan.org/pod/release/FREW/DBIx-Class-Helpers-2.026000/lib/DBIx/Class/Helper/Schema/Verifier.pm

[mcsnolte]

Looks perfect! Cool, I hope I can work on this soon

[frioux]

If not I'll get around to it eventually

sent from a rotary phone, pardon my brevity
On May 4, 2015 10:46 PM, "Steve Nolte" notifications@github.com wrote:

Looks perfect! Cool, I hope I can work on this soon

—
Reply to this email directly or view it on GitHub
#31 (comment)
.

[frioux]

Got the relname != colname one released

[frioux]

I'm gonna call this done. Create issues for each one that you think is worth doing.