Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support require #4

Closed
dbackeus opened this issue Oct 11, 2016 · 4 comments
Closed

Support require #4

dbackeus opened this issue Oct 11, 2016 · 4 comments

Comments

@dbackeus
Copy link

The common way to deal with React packages is to require them as modules. Would be nice to see support for this in this package.

@dbackeus
Copy link
Author

dbackeus commented Oct 11, 2016

In fact I was not able to get this to work in our webpack based project using require for code embedding rather than module assignment.

For example when var FroalaEditorFunctionality = { ... } is embedded on require it will not actually assign it globally (on window) so the objects are not accessible outside the scope of the individual files themself.

@BelfordZ
Copy link

would like to use this, but without webpack support as mentioned its a no-go.

@Inucoder
Copy link

I agree it should be possible to require the files as modules as that is the JS/React standard. I was able to workaround it by copying the code and adding the missing import/export lines to each file. We are building our sources with Gulp + Browserify.

@stefanneculai
Copy link
Contributor

Version 2.3.5-1 supports require.

sharma-dark-knight pushed a commit to sharma-dark-knight/react-froala-wysiwyg that referenced this issue Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants