Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pasting problems from Addy Osmani's JavaScript book #552

Closed
dandv opened this issue May 7, 2015 · 5 comments
Closed

Pasting problems from Addy Osmani's JavaScript book #552

dandv opened this issue May 7, 2015 · 5 comments

Comments

@dandv
Copy link

dandv commented May 7, 2015

  1. Copy some text+code from http://addyosmani.com/resources/essentialjsdesignpatterns/book/

    image

  2. Paste in Froala

image

By comparison, in CLEditor:

image

@stefanneculai
Copy link
Contributor

Last commit adds the new lines that were missing. The fact that the rest of the style is not copied is not an issue. CLEditor keeps all the inline style from the original site which is a total no from us.

@dandv
Copy link
Author

dandv commented May 8, 2015

Thanks Stefan. Has https://www.froala.com/wysiwyg-editor/customize been updated by any chance? Would be nice to see how the text pastes now in the demo.

I've been comparing ~50 WYSIWYG editors and Froala was one of the most promising.

@stefanneculai
Copy link
Contributor

We're updating the website version as soon as we make the release of the version 1.2.7. That will be for sure during next week.

@dandv
Copy link
Author

dandv commented May 29, 2015

Just checking if the site has been updated. Now the line numbers are more in-synch (though not perfectly aligned), but the syntax highlight is gone:

image

Is this a limitation as you mentioned earlier and unlikely to get fixed? In other words, is this the most that Froala plans to do in order to support pasting rich content?

@stefanneculai
Copy link
Contributor

We're currently working on an improved version for the editor 2.0.0. The new version will have better cleaning algorithms and options for keeping inline styles if someone may want that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants