Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing default response (HTTP/204) for DELETE handlers #26

Closed
frol opened this issue Sep 23, 2016 · 1 comment
Closed

Add missing default response (HTTP/204) for DELETE handlers #26

frol opened this issue Sep 23, 2016 · 1 comment
Labels
bug

Comments

@frol
Copy link
Owner

frol commented Sep 23, 2016

  • DELETE handlers in teams lack the documentation for the default (OK) response
  • DELETE handlers in teams should return HTTP/204 code instead of HTTP/200 since the body is empty

This issue is related to #25.

/cc @khorolets
@frol frol mentioned this issue Sep 23, 2016
Open
@frol frol added the bug label Sep 23, 2016
khorolets added a commit to khorolets/flask-restplus-server-example that referenced this issue Sep 23, 2016
@khorolets
frol#26 Add missing default response (HTTP/204) for DELETE handlers
d399b15 
Refactor response decorator in namespace of flast_resplus_patched
Add response(code=204) to delete in teams/resources.py
Updated team delete test to expect 204 status instead of 200
@khorolets
Copy link
Collaborator

khorolets commented Sep 23, 2016 •
edited
Loading

Made PR for this. If I'm not mistaken it affects #25 as well.

@khorolets khorolets mentioned this issue Sep 23, 2016
Merged
@frol frol closed this as completed in #28 Sep 24, 2016
frol pushed a commit that referenced this issue Sep 24, 2016
@khorolets @frol
Refactor response decorator in namespace of flask_resplus_patched (#28)
7dc29bc 
* Refactor response decorator in namespace of flask_resplus_patched (#25)
* Add response(code=204) to delete in teams/resources.py (#26)
* Updated team delete test to expect 204 status instead of 200 (#26)
* Add constant for status code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@frol @khorolets