Add missing default response (HTTP/204) for DELETE handlers #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khorolets
force-pushed
the
default_response_for_delete
branch
from
d399b15
to
b9ce629
Compare
khorolets
force-pushed
the
default_response_for_delete
branch
from
b9ce629
to
da51295
Compare
frol
changed the title
frol
requested changes
Sep 23, 2016
| @@ -111,6 +111,7 @@ def patch(self, args, team): | |||
| ) | |||
| @api.permission_required(permissions.WriteAccessPermission()) | |||
| @api.response(code=http_exceptions.Conflict.code) | |||
| @api.response(code=204) | |||
There was a problem hiding this comment.
204 is still used as a hard-coding here. Later, I would like to replace the http_exceptions with this http module.
khorolets
force-pushed
the
default_response_for_delete
branch
2 times, most recently
from
324035b
to
3860d2f
Compare
frol
requested changes
Sep 24, 2016
| @@ -14,13 +14,14 @@ | |||
| from app.extensions.api.parameters import PaginationParameters | |||
| from app.modules.users import permissions | |||
| from app.modules.users.models import User | |||
| from flask.ext.restplus_patched._http import HTTPStatus | |||
There was a problem hiding this comment.
This is a deprecated way of importing flask extentions. Please, just use from flask_restplus_patched... and also put it in the previous group of imports.
Add response(code=204) to delete in teams/resources.py Updated team delete test to expect 204 status instead of 200 Add constant for status code
khorolets
force-pushed
the
default_response_for_delete
branch
from
3860d2f
to
90ac8ee
Compare
frol
reviewed
Sep 24, 2016
|
|
||
| from app.extensions import db | ||
| from app.extensions.api import Namespace, abort, http_exceptions | ||
| from app.extensions.api.parameters import PaginationParameters | ||
| from app.modules.users import permissions | ||
| from app.modules.users.models import User | ||
|
|
||
|
|
There was a problem hiding this comment.
There is no need in this extra space line, but I will merge and we just fix this later.
frol
approved these changes
Sep 24, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26: Add missing default response (HTTP/204) for DELETE handlers
Refactor response decorator in namespace of flasл_resplus_patched
Add response(code=204) to delete in teams/resources.py
Updated team delete test to expect 204 status instead of 200
I will provide constant for 204-code in one of future commit if you don't mind. Any of packages haven't what you want. We have to create our own constants.