Update flask_restplus_patched to have a possibility to use non model … #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frol
requested changes
Oct 10, 2016
| @@ -138,13 +140,13 @@ def dump_wrapper(*args, **kwargs): | |||
| # pylint: disable=missing-docstring | |||
| response = func(*args, **kwargs) | |||
|
|
|||
| if isinstance(response, flask.Response): | |||
| if isinstance(response, flask.Response) or model is None: | |||
There was a problem hiding this comment.
Ouch, HTTP/204 tests failed... We need to move this whole if after the elif (so this if will become elif, and that elif will be if).
khorolets
force-pushed
the
allow_use_nonmodel_schemas
branch
from
abb879f
to
44d1aeb
Compare
1 similar comment
frol
requested changes
Oct 10, 2016
|
|
||
| elif response is None: | ||
| if code == HTTPStatus.NO_CONTENT: | ||
| if response is None: |
There was a problem hiding this comment.
Please, remove one blank line above.
…Schemas to response with code 200
khorolets
force-pushed
the
allow_use_nonmodel_schemas
branch
from
44d1aeb
to
85c675b
Compare
frol
approved these changes
Oct 10, 2016
1 similar comment
frol
pushed a commit
that referenced
this pull request
Dec 7, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update flask_restplus_patched to have a possibility to use non model Schemas to response with code 200