Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

feat: support latest deno.ns #2

Merged
merged 3 commits into from
Oct 24, 2021
Merged

feat: support latest deno.ns #2

merged 3 commits into from
Oct 24, 2021

Conversation

dsherret
Copy link
Contributor

I haven't tested this, but this shows the basic idea of how this could work.

@MKRhere
Copy link
Member

MKRhere commented Oct 20, 2021

Thanks for the PR! Looks reasonable, I'll test it works as expected in a while.

@dsherret dsherret mentioned this pull request Oct 20, 2021
Merged
@wojpawlik
Copy link
Member

I'd rather tests was require(importName).testDefinitions if available, [] otherwise

dsherret
dsherret commented Oct 20, 2021
View reviewed changes
src/api.js Show resolved Hide resolved
@wojpawlik
Copy link
Member

To work reliably, deno.ns must become an optional peer dependency: https://github.com/denoland/deno.ns/pull/26/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519

@wojpawlik
Copy link
Member

@MKRhere please test this. While I see nothing wrong here, I couldn't get it to actually work.

@MKRhere
Copy link
Member

MKRhere commented Oct 23, 2021

Works fine for me. I installed deno.ns@latest and dsherret/test#deno.ns.

image

image

@wojpawlik wojpawlik marked this pull request as ready for review October 23, 2021 13:04
@wojpawlik wojpawlik merged commit e8d6d61 into fromdeno:main Oct 24, 2021
@dsherret dsherret deleted the deno.ns branch October 25, 2021 16:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MKRhere MKRhere MKRhere approved these changes

@wojpawlik wojpawlik wojpawlik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsherret @MKRhere @wojpawlik