Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to @mdx-js/mdx v. 1 #49

Merged
merged 5 commits into from
May 30, 2019
Merged

Upgrade to @mdx-js/mdx v. 1 #49

merged 5 commits into from
May 30, 2019

Conversation

adueck
Copy link
Contributor

@adueck adueck commented May 30, 2019

This will fix issues #47 and #45.

Needed to include https://www.npmjs.com/package/@mdx-js/react for things to work because of breaking changes in @mdx-js/mdx v. 1

@jamesknelson
Copy link
Collaborator

Thanks for this! One more request: could you remove the dependency on @mdx-js/tag from both files? As I understand it, it's no longer needed for version 1.

@adueck
Copy link
Contributor Author

adueck commented May 30, 2019

No prob. Glad I could help out with this awesome thing which was just what I needed! 😃

You're right, @mdx-js/tag is no longer needed, I just tested and it works great without it.

@jamesknelson jamesknelson merged commit ef12e93 into frontarm:master May 30, 2019
@jamesknelson
Copy link
Collaborator

Published as 3.0.0 🎉

Thanks for your work on this!

@adueck
Copy link
Contributor Author

adueck commented May 30, 2019

Glad to help out! Might also want to upgrade mdx.macro in the same way? 🤔

@jamesknelson
Copy link
Collaborator

Just had an attempt at this in the mdx-macro--1 branch, although it appears that the whole transform would need to be rewritten from scratch.

Given that mdx.macro doesn't really work anyway (it doesn't handle auto-reload due to a limitation in babel-plugin-macros), I'm going to skip it for now. Would be happy to accept another PR though.

@adueck
Copy link
Contributor Author

adueck commented May 30, 2019

Ya using this instead of mdx.macro is definately the way to go. (Working without live reloading would be awful...) I'm gonna put in a PR to suggest mentioning the mdx-loader in the mdx docs section on using mdx with creat-react-app. Best solution hands down I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants