Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the use-in-view hook #251

Merged
merged 1 commit into from
Dec 18, 2019
Merged

fix the use-in-view hook #251

merged 1 commit into from
Dec 18, 2019

Conversation

michalczaplinski
Copy link
Member

@michalczaplinski michalczaplinski commented Dec 17, 2019

Description of what you did:

This fixes the occasional

TypeError: setFunction is undefined

in the twentytwenty theme

My PR is a:

  • πŸ” Improvement

Is the PR ready to be merged?

  • βœ… Yes!

Fixes #241

@changeset-bot
Copy link

changeset-bot bot commented Dec 17, 2019

πŸ¦‹ Changeset is good to go

Latest commit: b937258

We got this.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@luisherranz luisherranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Michal.

The PR is approved so feel free to merge it, but don't forget to add a changeset first with a patch to @frontity/hooks.

@luisherranz
Copy link
Member

You can add the changeset file in a separate commit, don't worry. You can even modify it in a later commit if needed. The final changelog entry generated will link to this PR, so it works fine :)

@michalczaplinski
Copy link
Member Author

michalczaplinski commented Dec 18, 2019 via email

@michalczaplinski michalczaplinski merged commit 9c8e9d8 into beta Dec 18, 2019
@luisherranz
Copy link
Member

I just write Add changeset πŸ˜†

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants