Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose head and scripts API on frontity namespace #725

Merged
merged 5 commits into from
Feb 25, 2021
Merged

Expose head and scripts API on frontity namespace #725

merged 5 commits into from
Feb 25, 2021

Conversation

cristianbote
Copy link
Member

What:

Expose the .head and .scripts API on frontity namespace.

Why:

For ease of defining custom head tags and scripts tags for rendering the document.

Tasks:

  • Code
  • TSDocs
  • TypeScript
  • Unit tests
  • End to end tests
  • TypeScript tests
  • Update other packages
  • Update community discussions
  • Add a changeset (with link to its Feature Discussion if it exists)

Unrelated Tasks

  • Update starter themes

Additional Comments

@cristianbote cristianbote self-assigned this Feb 22, 2021
@changeset-bot
Copy link

changeset-bot bot commented Feb 22, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: beb71be

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@frontity/core Patch
@frontity/types Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Feb 22, 2021 •
edited
Loading

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

@codecov
Copy link

codecov bot commented Feb 22, 2021 •
edited
Loading

Codecov Report

Merging #725 (a9ee85f) into dev (7493f01) will decrease coverage by 0.16%.
The diff coverage is 40.00%.

Impacted Files Coverage Δ
packages/amp/src/index.tsx 77.50% <18.19%> (-19.37%) ⬇️
packages/amp/src/template.ts 100.00% <100.00%> (ø)
...re/src/server/middlewares/capabilities/template.ts 50.00% <100.00%> (+12.50%) ⬆️
...re/src/server/middlewares/server-side-rendering.ts 90.33% <100.00%> (ø)

@cristianbote cristianbote requested review from michalczaplinski and DAreRodz and removed request for luisherranz February 23, 2021 13:15
michalczaplinski
michalczaplinski reviewed Feb 25, 2021
View reviewed changes
e2e/packages/static-theme/src/index.tsx
Comment on lines +151 to +162
.blink {
animation: blink 500ms linear infinite;
}

@keyframes blink {
from {
opacity: 1;
}
to {
opacity: 0;
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

michalczaplinski
michalczaplinski approved these changes Feb 25, 2021
View reviewed changes
Copy link
Member

@michalczaplinski michalczaplinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome @cristianbote. I just fixed very minor some typos and added a couple extra comments. Approved! 👍

@cristianbote
Copy link
Member Author

Thank you @michalczaplinski! 🙏

@cristianbote cristianbote merged commit 4aa44f9 into dev Feb 25, 2021
@cristianbote cristianbote deleted the expose-head-and-scripts-api branch February 25, 2021 07:03
@github-actions
Copy link
Contributor

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

@frontibotito frontibotito mentioned this pull request Mar 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalczaplinski michalczaplinski michalczaplinski approved these changes

@DAreRodz DAreRodz Awaiting requested review from DAreRodz

Assignees

@cristianbote cristianbote

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cristianbote @michalczaplinski