Stuff has been done! #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I moved ethereum-connector.js in lib in order to preload the web3 object. I learned about lib/ preloading from your YouTube video. I renamed contract.js to ethereum-contract.js because the preloading is done in alphabetical order by filename. I want this file to be loaded second, otherwise it won’t know about the web3 object! I also moved the functions in a file loaded lastly, otherwise it will give an error once about not knowing about the GuessNumberInstance object (even though it will still work fine). I also ran meteor update on the app. Tested, now it works flawlessly with both Chrome and Firefox. I don’t know JavaScript btw, I’m learning now. This is my first pull request ever, please tell me what I did wrong!
| if (typeof web3 == "undefined") { | ||
| web3 = new Web3(new Web3.providers.HttpProvider("http://localhost:8545")); | ||
| } | ||
| else if (!web3.currentProvider) |
There was a problem hiding this comment.
I would move that in the same row as the }, so } else if(...) {...}.
and you actually wouldn't need to do anything if web3 already exists, because then you're in mist and the provider is already set.
So please remove line 4-7
|
Thanks a lot! and congratulations for your first PR, please fix the issue pointed out in my comments and i will merge. |
|
I don't know how this works... I've done a commit in my branch with the modifications that you requested. Now... do I have to make the pull request again? |
|
No if you pushed to your branch, than its already in, e0111fd right? |
|
Yes, I pushed. e0111fd |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved ethereum-connector.js in lib in order to preload the web3 object.
I learned about lib/ preloading from your YouTube video.
I renamed contract.js to ethereum-contract.js because the preloading is done in alphabetical order by filename. I want this file to be loaded second, otherwise it won’t know about the web3 object! I also moved the functions in a file loaded lastly, otherwise it will give an error once about not knowing about the GuessNumberInstance object (even though it will still work fine).
I also ran meteor update on the app.
Tested, now it works flawlessly with both Chrome and Firefox. I don’t know JavaScript btw, I’m learning now. This is my first pull request ever, please tell me what I did wrong!